-
Notifications
You must be signed in to change notification settings - Fork 997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle registrations with bad proofs of possession #52
Comments
Ah, the IMO as a general principle, we should not be allowing no-op messages to get included in the chain as much as possible. |
Does this mean that if someone screws up the PoP their 32 ETH deposit goes in a black hole? |
Wouldn't it be possible to submit PoP to the registration contract once again? Maybe there are any drawbacks related to that? |
I suppose if we want we can add a mechanism for later re-submitting a "fixed PoP" for a previous deposit. |
Yeah, I'm open to it. I'd say this is a "nice to have", not a "must have". |
Agree. You can screw yourself over by submitting a bad withdrawal address already. |
What about:
This potentially kills several birds with one stone:
|
Moving registration logic to the beacon chain makes it possible to feature shards with validator registration. Should be a straightforward solution for that 👍 |
I like how this naturally translates to keeping the same interface for shard chain deposits, but there are certainly some other complexities introduced as a tradeoff. With the "deposit" contract, how does a validator utilize the eth1.0 ETH on eth2.0? If we use the eth1.0 pub-keys as the "right" to utilize the burned ETH, then we need to support ECDSA-verify on the beacon chain to verify that the Also, we'd be consuming SpecialRecords that point to successful TXs on the PoW chain rather than ordered logs from a contract on the PoW chain. This isn't radically different, but it introduces some required beacon chain accounting related to what has or hasn't been consumed from the eth1.0 deposit addr. |
To address your point about the beacon needing to support ECDSA-verify what about having a minimal contract where the only argument is |
At the moment validators with a bad proof of possession are
assert
ed away in theadd_validator
function. One possible way to handle bad proofs of possession is to add a corresponding validator entry with statusPENDING_WITHDRAW
.The text was updated successfully, but these errors were encountered: