You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For EL, I guess EL wanted to simplify it and didn't want to introduce the SSZ ByteVector definition?
However, Vector is also an SSZ definition, so it doesn't wrap up SSZ much.
In the EIP Networking section, it says "blobs - list of blob bytes where each blob is its BLSFieldElement list flattened in big endian". It seems using ByteVector would reduce this note? Also, if we use ByteVector, we can remove the BLSFieldElement definition from EIP.
Therefore, I'm inclined to update the EIP to ByteVector format.
The text was updated successfully, but these errors were encountered:
WRT first question, I think at some point in we decided on VERSIONED_HASH_VERSION_KZG but we never updated the EIP. I have a small preference for VERSIONED_HASH_VERSION_KZG, but it's also OK by me if someone prefers the other naming.
There is still some naming inconsistencies between EIP-4844 and consensus-specs:
Configs/constants
BLOB_COMMITMENT_VERSION_KZG
VERSIONED_HASH_VERSION_KZG
One of them should be renamed.
VERSIONED_HASH_VERSION_KZG
means the version "KZG" ofVersionedHash
.BLOB_COMMITMENT_VERSION
means the version of "blob commitment"?/cc EIP authors: @dankrad @asn-d6 and co, what do you think about it?
Custom types
Blob: Vector[BLSFieldElement, FIELD_ELEMENTS_PER_BLOB]
Blob: ByteVector[BYTES_PER_FIELD_ELEMENT * FIELD_ELEMENTS_PER_BLOB]
ByteVector
definition?Vector
is also an SSZ definition, so it doesn't wrap up SSZ much.blobs
- list ofblob
bytes where each blob is itsBLSFieldElement
list flattened inbig endian
". It seems usingByteVector
would reduce this note? Also, if we useByteVector
, we can remove theBLSFieldElement
definition from EIP.Therefore, I'm inclined to update the EIP to
ByteVector
format.The text was updated successfully, but these errors were encountered: