Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync EIP-4844 and consensus-specs definitions #3462

Closed
hwwhww opened this issue Jul 25, 2023 · 2 comments
Closed

Sync EIP-4844 and consensus-specs definitions #3462

hwwhww opened this issue Jul 25, 2023 · 2 comments
Labels
Deneb was called: eip-4844

Comments

@hwwhww
Copy link
Contributor

hwwhww commented Jul 25, 2023

There is still some naming inconsistencies between EIP-4844 and consensus-specs:

Configs/constants

EIP CL-specs
BLOB_COMMITMENT_VERSION_KZG VERSIONED_HASH_VERSION_KZG

One of them should be renamed.

  • For CL, VERSIONED_HASH_VERSION_KZG means the version "KZG" of VersionedHash.
  • For EL, It sounds like BLOB_COMMITMENT_VERSION means the version of "blob commitment"?

/cc EIP authors: @dankrad @asn-d6 and co, what do you think about it?

Custom types

EIP CL-specs
Blob: Vector[BLSFieldElement, FIELD_ELEMENTS_PER_BLOB] Blob: ByteVector[BYTES_PER_FIELD_ELEMENT * FIELD_ELEMENTS_PER_BLOB]
  • They are the same binary data in marshaling.
  • CL requires this format in KZG and libraries.
  • For EL, I guess EL wanted to simplify it and didn't want to introduce the SSZ ByteVector definition?
    • However, Vector is also an SSZ definition, so it doesn't wrap up SSZ much.
    • In the EIP Networking section, it says "blobs - list of blob bytes where each blob is its BLSFieldElement list flattened in big endian". It seems using ByteVector would reduce this note? Also, if we use ByteVector, we can remove the BLSFieldElement definition from EIP.

Therefore, I'm inclined to update the EIP to ByteVector format.

@hwwhww hwwhww added the Deneb was called: eip-4844 label Jul 25, 2023
@asn-d6
Copy link
Contributor

asn-d6 commented Jul 27, 2023

WRT first question, I think at some point in we decided on VERSIONED_HASH_VERSION_KZG but we never updated the EIP. I have a small preference for VERSIONED_HASH_VERSION_KZG, but it's also OK by me if someone prefers the other naming.

@hwwhww
Copy link
Contributor Author

hwwhww commented Aug 3, 2023

closing via ethereum/EIPs#7429

@hwwhww hwwhww closed this as completed Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deneb was called: eip-4844
Projects
None yet
Development

No branches or pull requests

3 participants
@asn-d6 @hwwhww and others