Blocks added to the store before some verifications

[terencechain]

The block gets added to the store before checking it's a descendant of the finalized block and later than the finalized epoch slot. Any reason it is added before those verifications?
The appropriate spot looks to be after state transition

[hwwhww]

Because with the current algorithm, the given block would be queried in get_ancestor(store: Store, root: Hash, slot: Slot) function recursively.
I had the same question before: #1068 (comment), but we haven't figured out a better solution yet.

We do want to make the fork choice rule spec more abstract in the spec level, however for sanity testing, the Store is exposed as status quo. IMO it might need more iterations past spec freeze to make it better.

[JustinDrake]

@terencechain: Can we close this?

[terencechain]

Sure and to clarify this is just a presentation issue. In Prysm, we add the block to fork choice store after state_transition