From e21ed6de4f81b0ce9115694753f12f19fafd5fc0 Mon Sep 17 00:00:00 2001 From: danny Date: Thu, 2 Nov 2023 10:03:56 -0600 Subject: [PATCH] clarify/fix things in blob requests --- specs/deneb/p2p-interface.md | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/specs/deneb/p2p-interface.md b/specs/deneb/p2p-interface.md index 17e673c50e..0e53af83a3 100644 --- a/specs/deneb/p2p-interface.md +++ b/specs/deneb/p2p-interface.md @@ -286,10 +286,7 @@ Requests sidecars by block root and index. The response is a list of `BlobSidecar` whose length is less than or equal to the number of requests. It may be less in the case that the responding peer is missing blocks or sidecars. -The response is unsigned, i.e. `BlobSidecar`, as the signature of the beacon block proposer -may not be available beyond the initial distribution via gossip. - -Before consuming the next response chunk, the response reader SHOULD verify the blob sidecar is well-formatted and correct w.r.t. the expected KZG commitments through `verify_blob_kzg_proof_batch`. +Before consuming the next response chunk, the response reader SHOULD verify the blob sidecar is well-formatted, has valid inclusion proof, and is correct w.r.t. the expected KZG commitments through `verify_blob_kzg_proof`. No more than `MAX_REQUEST_BLOB_SIDECARS` may be requested at a time. @@ -334,9 +331,7 @@ Response Content: Requests blob sidecars in the slot range `[start_slot, start_slot + count)`, leading up to the current head block as selected by fork choice. -The response is unsigned, i.e. `BlobSidecarsByRange`, as the signature of the beacon block proposer may not be available beyond the initial distribution via gossip. - -Before consuming the next response chunk, the response reader SHOULD verify the blob sidecar is well-formatted and correct w.r.t. the expected KZG commitments through `verify_blob_kzg_proof_batch`. +Before consuming the next response chunk, the response reader SHOULD verify the blob sidecar is well-formatted, has valid inclusion proof, and is correct w.r.t. the expected KZG commitments through `verify_blob_kzg_proof`. `BlobSidecarsByRange` is primarily used to sync blobs that may have been missed on gossip and to sync within the `MIN_EPOCHS_FOR_BLOB_SIDECARS_REQUESTS` window.