From 393f9b8f2fee23d2dd057fde92e5c93581373c23 Mon Sep 17 00:00:00 2001 From: Suphanat Chunhapanya Date: Tue, 24 May 2022 20:12:51 +0700 Subject: [PATCH] EIP-4844: Change to versioned hashes In the validate_blob_transaction_wrapper function, it uses blob_commmitments which doesn't make sense. It makes more sense when it uses blob_versioned_hashes instead. --- EIPS/eip-4844.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/EIPS/eip-4844.md b/EIPS/eip-4844.md index 326698641958d6..cc4422fb090e36 100644 --- a/EIPS/eip-4844.md +++ b/EIPS/eip-4844.md @@ -351,14 +351,14 @@ We do network-level validation of `BlobTransactionNetworkWrapper` objects as fol ```python def validate_blob_transaction_wrapper(wrapper: BlobTransactionNetworkWrapper): - commitments = wrapper.tx.message.blob_commitments + versioned_hashes = wrapper.tx.message.blob_versioned_hashes kzgs = wrapper.blob_kzgs blobs = wrapper.blobs - assert len(commitments) == len(kzgs) == len(blobs) - for commitment, kzg, blob in zip(commitments, kzgs, blobs): + assert len(versioned_hashes) == len(kzgs) == len(blobs) + for versioned_hash, kzg, blob in zip(versioned_hashes, kzgs, blobs): # note: assert blob is not malformatted assert kzg == blob_to_kzg(blob) - assert commitment == kzg_to_commitment(kzg) + assert versioned_hash == kzg_to_versioned_hash(kzg) ``` ## Rationale