Skip to content
This repository has been archived by the owner on Feb 9, 2023. It is now read-only.

EIP Bot should not require changes to the EIP file to modify EIP asset files #95

Open
Pandapip1 opened this issue Jul 11, 2022 · 6 comments
Labels
bug Something isn't working priority: medium

Comments

@Pandapip1
Copy link
Member

See ethereum/EIPs#5213

Example error:

file assets/eip-4907/contracts/ERC4907.sol is associated with EIP 4907 but there are no changes being made to corresponding EIP itself. To assure that the change is authorized by the relevant stake-holders, you must also make changes to the EIP file itself for the asset changes to be eligible for auto-merge

@Pandapip1 Pandapip1 changed the title EIP Bot should not require changes to an EIP to modify EIP asset files EIP Bot should not require changes to the EIP file to modify EIP asset files Jul 11, 2022
@Pandapip1 Pandapip1 added bug Something isn't working priority: medium labels Aug 10, 2022
@JEAlfonsoP
Copy link
Contributor

Question: is there a determined list for "normal rules for changing files in assets directory" ?

@Pandapip1
Copy link
Member Author

is there a determined list for "normal rules for changing files in assets directory" ?

No, except for "the EIP has to be modified too."

@JEAlfonsoP
Copy link
Contributor

To make this clear:

If any EIP-asset file is modified the EIP-Bot fails and requests authors to modify EIP-File itself ?

Is there some one else working on it ?

@Pandapip1
Copy link
Member Author

No, nobody else it working on it. Go ahead!

@JEAlfonsoP
Copy link
Contributor

Roger that, I will take a look on it..

@SamWilsn
Copy link

SamWilsn commented Sep 7, 2022

Nope, I'm not working on this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working priority: medium
Projects
None yet
Development

No branches or pull requests

3 participants