Skip to content
This repository has been archived by the owner on Feb 9, 2023. It is now read-only.

Propose alternative solution for issue #65: **_Set created date in the preamble immediately before merging new EIP pull requests_** #78

Closed
JEAlfonsoP opened this issue May 2, 2022 · 0 comments

Comments

@JEAlfonsoP
Copy link
Contributor

JEAlfonsoP commented May 2, 2022

Propose alternative solution for issue #65: Set created date in the preamble immediately before merging new EIP pull requests

Proposal:
add an assertion in: EIP-Bot/src/modules/assertions/ that immediately before merging, warns author to include created date in Preamble and displays the created_at date for the repo:

/*Issue #65, Originally from #55
Immediately before merging (IMO, ideally in the merge commit itself) set the created date in the preamble.
Creator: SamWilsn
to be included in /src/modules/assertions */

import { context, getOctokit } from "@actions/github";
import {
GITHUB_TOKEN,
GithubSelf,
PR,
} from "src/domain";
import _ from "lodash";

export const getCreatedAt = () => {
const github = getOctokit(GITHUB_TOKEN).rest;
console.log(Warning: Please ensure to include in template PR Created date: +context.payload?.pull_request?.created_at);

};

// Copyright and related rights waived via CC0.

@JEAlfonsoP JEAlfonsoP mentioned this issue May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant