Support for empty params and install arguments (#4)

ethanbergstrom · Sep 24, 2021 · f04fbbf · f04fbbf
1 parent 7266ace
commit f04fbbf
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.0.8] - 2021-09-24
+#### Added
+* Support for empty package parameters and install arguments
+
 ## [0.0.7] - 2021-07-11
 #### Added
 * Specific Cmdlet descriptions in Get-Help documentation

diff --git a/src/Foil.ps1 b/src/Foil.ps1
@@ -150,9 +150,10 @@ $Commands = @(
                     },
                     @{
                         Name = 'Parameters'
-                        OriginalName = '--parameters'
+                        OriginalName = '--parameters='
                         ParameterType = 'string'
                         Description = 'Parameters to pass to the package'
+                        NoGap = $true
                     },
                     @{
                         Name = 'ArgsGlobal'
@@ -162,9 +163,10 @@ $Commands = @(
                     },
                     @{
                         Name = 'InstallArguments'
-                        OriginalName = '--install-arguments'
+                        OriginalName = '--install-arguments='
                         ParameterType = 'string'
                         Description = 'Parameters to pass to the package'
+                        NoGap = $true
                     },
                     @{
                         Name = 'Source'

diff --git a/test/Foil.tests.ps1 b/test/Foil.tests.ps1
@@ -76,6 +76,18 @@ Describe "pipline-based package installation and uninstallation" {
 			Get-ChocoPackage -Name $package -LocalOnly -Exact | Uninstall-ChocoPackage | Where-Object {$_.Name -contains $package} | Should -Not -BeNullOrEmpty
 		}
 	}
+	Context 'with empty arguments' {
+		BeforeAll {
+			$package = 'cpu-z'
+		}
+
+		It 'searches for and silently installs the latest version of a package' {
+			Get-ChocoPackage -Name $package | Install-ChocoPackage -Force -Parameters '' | Where-Object {$_.Name -contains $package} | Should -Not -BeNullOrEmpty
+		}
+		It 'finds and silently uninstalls the locally installed package just installed' {
+			Get-ChocoPackage -Name $package -LocalOnly -Exact | Uninstall-ChocoPackage | Where-Object {$_.Name -contains $package} | Should -Not -BeNullOrEmpty
+		}
+	}
 	Context 'with additional parameters' {
 		BeforeAll {
 			$package = 'sysinternals'