Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle exceptions raised by eth_estimateGas #184

Closed
iamdefinitelyahuman opened this issue Sep 11, 2019 · 0 comments
Closed

Handle exceptions raised by eth_estimateGas #184

iamdefinitelyahuman opened this issue Sep 11, 2019 · 0 comments
Labels
bug Something isn't working priority Should be included in next release

Comments

@iamdefinitelyahuman
Copy link
Member

Related issue: trufflesuite/ganache#462
Related PR: trufflesuite/ganache#457

Changes in ganache-core have broken brownie when estimating gas for a would-be-failing transaction. This new behavior is consistent with geth or parity, however, so this issue was always present when using brownie for a non-local environment.

We should not assume that all users will be on the most up-to-date version of Ganache, or that the behavior won't change again or be handled differently by some other RPC client in the future - the call should be attempted, and the exception handled properly if it fails. Since Brownie requires
broadcasting failed tx's as part of running tests and evaluating coverage, the solution here might be to set the gas limit as == the block gas limit when an exception is raised.

@iamdefinitelyahuman iamdefinitelyahuman added bug Something isn't working priority Should be included in next release labels Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority Should be included in next release
Projects
None yet
Development

No branches or pull requests

1 participant