From b00646cb6e969ac02fa2d984d074c1f4d0e305df Mon Sep 17 00:00:00 2001 From: Benjamin Wang Date: Thu, 6 Jun 2024 19:28:59 +0100 Subject: [PATCH] print error log when validation on conf change failed Signed-off-by: Benjamin Wang --- server/etcdserver/server.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/server/etcdserver/server.go b/server/etcdserver/server.go index e32249f627e..62b97663a34 100644 --- a/server/etcdserver/server.go +++ b/server/etcdserver/server.go @@ -2351,7 +2351,9 @@ func (s *EtcdServer) notifyAboutFirstCommitInTerm() { // applyConfChange applies a ConfChange to the server. It is only // invoked with a ConfChange that has already passed through Raft func (s *EtcdServer) applyConfChange(cc raftpb.ConfChange, confState *raftpb.ConfState, shouldApplyV3 membership.ShouldApplyV3) (bool, error) { + lg := s.Logger() if err := s.cluster.ValidateConfigurationChange(cc); err != nil { + lg.Error("Validation on configuration change failed", zap.Bool("shouldApplyV3", bool(shouldApplyV3)), zap.Error(err)) cc.NodeID = raft.None s.r.ApplyConfChange(cc) @@ -2364,7 +2366,6 @@ func (s *EtcdServer) applyConfChange(cc raftpb.ConfChange, confState *raftpb.Con return false, err } - lg := s.Logger() *confState = *s.r.ApplyConfChange(cc) s.beHooks.SetConfState(confState) switch cc.Type {