Consider adopting go 1.20 as go 1.19 is now out of support

[jmhbnz]

What would you like to be added?

Golang 1.21 has now been released today:

• https://groups.google.com/g/golang-announce/c/Mk0Jar6hfhI
• https://go.dev/doc/go1.21

This means 1.19 is now out of support so we should consider adopting 1.20. This would also bring etcd in line with kubernetes/kubernetes go version.

Consider updating:

• etcd/main Migrate to golang 1.20 #16394
• etcd/release-3.5 [3.5] Backport update to golang 1.20 minor release #16401
• etcd/release-3.4 [3.4] Backport update to golang 1.20 minor release #16406
• bbolt/master Update to golang 1.20 minor release bbolt#555
• raft/main Update to golang 1.20 minor release raft#97

Why is this needed?

Ensure etcd is built using supported versions of golang. Ensure the project continues to apply timely security patches.

[ahrtr]

thx @jmhbnz

• There should be no any golang breaking change to etcd. I suggest to bump go version to 1.20 for all versions, including main/3.5/3.4;
• Can we do a simple benchmark comparison on the main branch?

[jmhbnz]

There should be no any golang breaking change to etcd. I suggest to bump go version to 1.20 for all versions, including main/3.5/3.4;

Can we do a simple benchmark comparison on the main branch?

Raised pr for main. Workflows passing and benchmark comparison posted in pr is looking pretty similar.

[jmhbnz]

Note there are two deprecations in 1.20 we should stay on top of:

• math/rand.Read Use crypto/rand.Read instead of deprecated math/rand.Read #16459
• math/rand.Seed all: stop using math/rand.Seed #16428

[serathius]

My thoughts, main branch should say to latest Go version (avoid taking dept, better upgrade earlier than later). Etcd supported branches should use supported Go version, latest patch, but avoid upgrading minor if possible (avoid distuptions).

So it would mean that go1.21 for main branch and go1.20 for release-3.4 and release-3.5.

[ahrtr]

So it would mean that go1.21 for main branch and go1.20 for release-3.4 and release-3.5.

Due to the faster release pace of golang (e.g. around 6 months for each a minor release), we have to upgrade to golang 1.21 for all etcd supported versions on around Feb 2024.

For the etcd main branch, it shouldn't be a big problem to upgrade to 1.21 earlier. But I tend to be consistent with K8s. Currently K8s is on golang 1.20 on master (1.28 was also released on golang 1.20). WDYT?

[serathius]

Kubernetes 1.28 was cut over a month ago, they only released it recently. They are already preparing for 1.21 kubernetes/kubernetes#119027

[jmhbnz]

My vote would be to aim that our main follows k/k master for go version where possible. Based on progress that will likely mean an update to 1.21 in the next couple of months. We have a couple minor 1.20 deprecations to tidy up under #16428 but those won't take long.

Agree we do minor version upgrades when necessary on supported release branches to keep them on a supported golang version but otherwise we just focus on staying on latest patch release.

[jmhbnz]

Closing, 1.20 upgrade complete 🎉