diff --git a/.golangci.yaml b/.golangci.yaml index 582bdfb1200..d169aa4e7fa 100644 --- a/.golangci.yaml +++ b/.golangci.yaml @@ -20,14 +20,17 @@ linters: # - deadcode # - structcheck # - varcheck + - goimports - ineffassign + - revive - staticcheck - stylecheck - unused - unconvert # Remove unnecessary type conversions - - revive linters-settings: # please keep this alphabetized + goimports: + local-prefixes: go.etcd.io # Put imports beginning with prefix after 3rd-party packages. staticcheck: checks: - "all" diff --git a/tools/benchmark/cmd/util.go b/tools/benchmark/cmd/util.go index ab644b3d4d7..45658bb5855 100644 --- a/tools/benchmark/cmd/util.go +++ b/tools/benchmark/cmd/util.go @@ -22,9 +22,10 @@ import ( "strings" "github.com/bgentry/speakeasy" + "google.golang.org/grpc/grpclog" + clientv3 "go.etcd.io/etcd/client/v3" "go.etcd.io/etcd/pkg/v3/report" - "google.golang.org/grpc/grpclog" ) var ( diff --git a/tools/benchmark/cmd/watch_latency.go b/tools/benchmark/cmd/watch_latency.go index 1f5a17d83cf..31ceb3b327e 100644 --- a/tools/benchmark/cmd/watch_latency.go +++ b/tools/benchmark/cmd/watch_latency.go @@ -21,12 +21,12 @@ import ( "sync" "time" - "go.etcd.io/etcd/client/v3" - "go.etcd.io/etcd/pkg/v3/report" - "github.com/cheggaaa/pb/v3" "github.com/spf13/cobra" "golang.org/x/time/rate" + + clientv3 "go.etcd.io/etcd/client/v3" + "go.etcd.io/etcd/pkg/v3/report" ) // watchLatencyCmd represents the watch latency command diff --git a/tools/etcd-dump-db/backend.go b/tools/etcd-dump-db/backend.go index 6205d5597f8..d44ff888c03 100644 --- a/tools/etcd-dump-db/backend.go +++ b/tools/etcd-dump-db/backend.go @@ -19,15 +19,14 @@ import ( "fmt" "path/filepath" - "go.etcd.io/etcd/api/v3/authpb" - "go.etcd.io/etcd/server/v3/storage/schema" "go.uber.org/zap" + bolt "go.etcd.io/bbolt" + "go.etcd.io/etcd/api/v3/authpb" "go.etcd.io/etcd/api/v3/mvccpb" "go.etcd.io/etcd/server/v3/lease/leasepb" "go.etcd.io/etcd/server/v3/storage/backend" - - bolt "go.etcd.io/bbolt" + "go.etcd.io/etcd/server/v3/storage/schema" ) func snapDir(dataDir string) string { diff --git a/tools/etcd-dump-logs/etcd-dump-log_test.go b/tools/etcd-dump-logs/etcd-dump-log_test.go index 4f209012276..5aa15ee9266 100644 --- a/tools/etcd-dump-logs/etcd-dump-log_test.go +++ b/tools/etcd-dump-logs/etcd-dump-log_test.go @@ -23,13 +23,14 @@ import ( "strings" "testing" + "go.uber.org/zap/zaptest" + "go.etcd.io/etcd/api/v3/authpb" "go.etcd.io/etcd/api/v3/etcdserverpb" "go.etcd.io/etcd/client/pkg/v3/fileutil" "go.etcd.io/etcd/pkg/v3/pbutil" "go.etcd.io/etcd/raft/v3/raftpb" "go.etcd.io/etcd/server/v3/storage/wal" - "go.uber.org/zap/zaptest" ) func TestEtcdDumpLogEntryType(t *testing.T) { diff --git a/tools/etcd-dump-logs/main.go b/tools/etcd-dump-logs/main.go index 4b7056004bc..3778d955a23 100644 --- a/tools/etcd-dump-logs/main.go +++ b/tools/etcd-dump-logs/main.go @@ -29,6 +29,8 @@ import ( "strings" "time" + "go.uber.org/zap" + "go.etcd.io/etcd/api/v3/etcdserverpb" "go.etcd.io/etcd/client/pkg/v3/types" "go.etcd.io/etcd/pkg/v3/pbutil" @@ -36,7 +38,6 @@ import ( "go.etcd.io/etcd/server/v3/etcdserver/api/snap" "go.etcd.io/etcd/server/v3/storage/wal" "go.etcd.io/etcd/server/v3/storage/wal/walpb" - "go.uber.org/zap" ) const ( diff --git a/tools/proto-annotations/cmd/etcd_version.go b/tools/proto-annotations/cmd/etcd_version.go index bd86e5a5076..2e75755572b 100644 --- a/tools/proto-annotations/cmd/etcd_version.go +++ b/tools/proto-annotations/cmd/etcd_version.go @@ -21,10 +21,10 @@ import ( "sort" "github.com/coreos/go-semver/semver" - "go.etcd.io/etcd/server/v3/storage/wal" - "google.golang.org/protobuf/reflect/protoreflect" "google.golang.org/protobuf/reflect/protoregistry" + + "go.etcd.io/etcd/server/v3/storage/wal" ) var (