From b5aaaeba54becb92f7e6928ef01e11fb6f27f022 Mon Sep 17 00:00:00 2001
From: Mustafa Elbehery <melbeher@redhat.com>
Date: Thu, 9 Nov 2023 15:30:31 +0100
Subject: [PATCH] fix: refactor findingLastBucket into a func

Signed-off-by: Mustafa Elbehery <melbeher@redhat.com>
---
 cmd/bbolt/main.go | 42 ++++++++++++++++++++++--------------------
 1 file changed, 22 insertions(+), 20 deletions(-)

diff --git a/cmd/bbolt/main.go b/cmd/bbolt/main.go
index 7ba8c8a7f..ea284539e 100644
--- a/cmd/bbolt/main.go
+++ b/cmd/bbolt/main.go
@@ -939,19 +939,13 @@ func (cmd *keysCommand) Run(args ...string) error {
 	// Print keys.
 	return db.View(func(tx *bolt.Tx) error {
 		// Find bucket.
-		var lastbucket *bolt.Bucket = tx.Bucket([]byte(buckets[0]))
-		if lastbucket == nil {
-			return berrors.ErrBucketNotFound
-		}
-		for _, bucket := range buckets[1:] {
-			lastbucket = lastbucket.Bucket([]byte(bucket))
-			if lastbucket == nil {
-				return berrors.ErrBucketNotFound
-			}
+		lastBucket, err := findLastBucket(tx, buckets)
+		if err != nil {
+			return err
 		}
 
 		// Iterate over each key.
-		return lastbucket.ForEach(func(key, _ []byte) error {
+		return lastBucket.ForEach(func(key, _ []byte) error {
 			return writelnBytes(cmd.Stdout, key, *optionsFormat)
 		})
 	})
@@ -1030,19 +1024,13 @@ func (cmd *getCommand) Run(args ...string) error {
 	// Print value.
 	return db.View(func(tx *bolt.Tx) error {
 		// Find bucket.
-		var lastbucket *bolt.Bucket = tx.Bucket([]byte(buckets[0]))
-		if lastbucket == nil {
-			return berrors.ErrBucketNotFound
-		}
-		for _, bucket := range buckets[1:] {
-			lastbucket = lastbucket.Bucket([]byte(bucket))
-			if lastbucket == nil {
-				return berrors.ErrBucketNotFound
-			}
+		lastBucket, err := findLastBucket(tx, buckets)
+		if err != nil {
+			return err
 		}
 
 		// Find value for given key.
-		val := lastbucket.Get(key)
+		val := lastBucket.Get(key)
 		if val == nil {
 			return fmt.Errorf("Error %w for key: %q hex: \"%x\"", ErrKeyNotFound, key, string(key))
 		}
@@ -1718,3 +1706,17 @@ func (_ cmdKvStringer) ValueToString(value []byte) string {
 func CmdKvStringer() bolt.KVStringer {
 	return cmdKvStringer{}
 }
+
+func findLastBucket(tx *bolt.Tx, bucketNames []string) (*bolt.Bucket, error) {
+	var lastbucket *bolt.Bucket = tx.Bucket([]byte(bucketNames[0]))
+	if lastbucket == nil {
+		return nil, berrors.ErrBucketNotFound
+	}
+	for _, bucket := range bucketNames[1:] {
+		lastbucket = lastbucket.Bucket([]byte(bucket))
+		if lastbucket == nil {
+			return nil, berrors.ErrBucketNotFound
+		}
+	}
+	return lastbucket, nil
+}