Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ref/hy/model separate #140

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Ref/hy/model separate #140

wants to merge 5 commits into from

Conversation

hoxirious
Copy link
Collaborator

  • Most of the deletion come from organizing and renaming files. I removed the counter slice since I believe that is just an example.
  • In the last PR, the 3-dot option was not displayed on single posts. It should be fixed now.

@hoxirious hoxirious requested a review from rjb75 April 14, 2022 21:31
@hoxirious hoxirious self-assigned this Apr 14, 2022
@github-actions github-actions bot added front-end Pertains to UI code on the front end redux Pertains to code which alters redux functionality scss Pertains to code which affects SCSS styling automerge Pull request should be automatically merged on passing checks and reviews labels Apr 14, 2022
This was linked to issues Apr 14, 2022
Separate Models #117
Open
Naming convention #118
Open
Separate Style #119
Open
@github-actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit 77c55c8):

https://ess-schulichhub-dev--pr140-ref-hy-model-separat-hc6az65z.web.app

(expires Thu, 21 Apr 2022 21:34:55 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjb75 rjb75 Awaiting requested review from rjb75

@lemohammed lemohammed Awaiting requested review from lemohammed

@MrClean-1 MrClean-1 Awaiting requested review from MrClean-1

@RatikKapoor RatikKapoor Awaiting requested review from RatikKapoor

At least 2 approving reviews are required to merge this pull request.

Assignees

@hoxirious hoxirious

Labels
automerge Pull request should be automatically merged on passing checks and reviews front-end Pertains to UI code on the front end redux Pertains to code which alters redux functionality scss Pertains to code which affects SCSS styling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Separate Style Naming convention Separate Models
1 participant
@hoxirious