Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nRF52 timer wakeups #1900

Closed
gfwilliams opened this issue Jul 29, 2020 · 1 comment
Closed

nRF52 timer wakeups #1900

gfwilliams opened this issue Jul 29, 2020 · 1 comment

Comments

@gfwilliams
Copy link
Member

Currently, TIMER1_IRQHandler calls jshHadEvent - so every timer event will take Espruino out of sleep and once around the idle loop.

On Bangle.js it's needed because the peripheralPollHandler doesn't call jshHadEvent (and it doesn't seem to make much/any noticeable difference to power consumption).

However it might be a bigger deal on some other devices that are more conscious of power - not that we generally use the timer by default anyway.

@gfwilliams
Copy link
Member Author

Note: recent bangle.js firmware uses app_timer not the util timer, so it's possible that as long as jstimer.c calls jshHadEvent correctly we'll be fine to remove it in TIMER1_IRQHandler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant