[VSC-1597] preBuild wrongly used in project conf idf.preFlashTask #1441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request: |
Fabricio-ESP
changed the title
Fabricio-ESP
approved these changes
Mar 12, 2025
|
Confirmed working as intended. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prebuild Task being used in flash task as pre flash task in Project Configuration Editor
Fixes #1438
Type of change
Steps to test this pull request
Provide a list of steps to test changes in this PR and required output
ESP-IDF: Project Configuration Editorand add a profile with"preBuild": "idf.py set-target esp32p4". Save itESP-IDF: Select Project Configurationto select previously defined profile.ESP-IDF: Flash Your Project. Previously you would see the prebuilt task being executed. In This PR, it should NOT be executed. Instead if you define"preFlash": "idf.py set-target esp32p4"inESP-IDF: Project Configuration Editorit should run before flash as intended.Expected behaviour:
PreBuild tasks should NOT execute before flashing
Expected output:
PreFlash task SHOULD execute before flashing.
How has this been tested?
Manual testing with steps above.
Test Configuration:
Checklist