Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(psram/eid): use a unique return value for errors (QEMU-241) #119

Open
wants to merge 1 commit into
base: esp-develop
Choose a base branch
from

Conversation

muggenhor
Copy link

@muggenhor muggenhor commented Jan 24, 2025

Description

This makes callers of get_eid_by_size able to distinguish the errors from success.

Related

Fixes #117

Testing

Ran an image with qemu-system-xtensa with -m 2M option and noticed that this error was present without patch but not with:

qemu-system-xtensa: [PSRAM] Invalid size 2MB for the PSRAM

Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

To be able to distinguish them from valid EIDs.

Fixes espressif#117
@github-actions github-actions bot changed the title fix(psram/eid): use a unique return value for errors fix(psram/eid): use a unique return value for errors (QEMU-241) Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PSRAM 2MB's EID indistinguishable from lookup failure (QEMU-239)
2 participants