Revert "Revert "json_parser: add idf_version rules for jsmn"" (IEC-29) #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
changed the title
|
What needs to be done to get this merged? |
mahavirj
approved these changes
Jul 17, 2023
This reverts commit 7b08cd0. The idf component manager now supports uploading components with rules.
mahavirj
force-pushed
the
task/json_parser_update
branch
from
ccacb63
to
714a669
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 7b08cd0.
The idf component manager now supports uploading components with rules.
Checklist
urlfield definedChange description
This just reverts an earlier change which was added due to a bug in idf component manager, which did not allow external components to have "rules" in dependencies. Now that the bug is fixed, we can add back the rules.