Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(esp_netif): Allow traffic reporting (IDFGH-12314) #13348

Conversation

mickeyl
Copy link
Contributor

@mickeyl mickeyl commented Mar 10, 2024

This enables traffic indicators or data traffic statistics.

It is a fairly small feature hidden behind the new configuration CONFIG_ESP_NETIF_REPORT_DATA_TRAFFIC.
It does not have any effect, if you choose not to configure it.

This enables traffic indicators or data traffic statistics.
Copy link

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello mickeyl, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against e0aca4e

@espressif-bot espressif-bot added the Status: Opened Issue is new label Mar 10, 2024
@github-actions github-actions bot changed the title feat(esp_netif): Allow traffic reporting feat(esp_netif): Allow traffic reporting (IDFGH-12314) Mar 10, 2024
@espressif-bot espressif-bot added Status: In Progress Work is in progress and removed Status: Opened Issue is new labels Apr 4, 2024
@espressif-abhikroy
Copy link
Collaborator

sha=e0aca4e14d77a29e81725efbb977636b0d84a972

@espressif-abhikroy espressif-abhikroy added the PR-Sync-Merge Pull request sync as merge commit label Apr 4, 2024
@espressif-bot espressif-bot added Status: Reviewing Issue is being reviewed Status: Done Issue is done internally Resolution: NA Issue resolution is unavailable and removed Status: In Progress Work is in progress Status: Reviewing Issue is being reviewed labels Apr 19, 2024
@Alvin1Zhang
Copy link
Collaborator

Thanks for contribution again, changes have been merged with 3cb622c.

@Alvin1Zhang Alvin1Zhang closed this May 7, 2024
@mickeyl
Copy link
Contributor Author

mickeyl commented Sep 5, 2024

Asking in general... can we find a schedule or information about for when a merged PR is scheduled to be in a release?

@AxelLin
Copy link
Contributor

AxelLin commented Sep 5, 2024

@espressif-abhikroy Looks like 5debb23 and ad9787b can be easily applied to v5.2 branch. Do you consider backport them to release branches?

@espressif-abhikroy
Copy link
Collaborator

Asking in general... can we find a schedule or information about for when a merged PR is scheduled to be in a release?

Unfortunately, the release schedule for IDF is not publicly available. Regarding the commits (5debb23 and ad9787b), they are currently only available on the master branch and will be included in the upcoming 5.4 release.

@espressif-abhikroy
Copy link
Collaborator

@espressif-abhikroy Looks like 5debb23 and ad9787b can be easily applied to v5.2 branch. Do you consider backport them to release branches?

This is a feature, and we typically do not backport features. Therefore, these commits were not considered for backporting. However, if necessary, we can consider it. Please let us know if you require it in an earlier release.

@dmitrij9992905
Copy link

I was surprised with fact that traffic reporting is not included even in v5.3.1, and I couldn't see it in v5.4-dev.
However, I tried it with esp-idf-master with GSM modem, and it could be useful for traffic accounting. I hope it will be included at least to v5.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Sync-Merge Pull request sync as merge commit Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants