Skip to content

Commit

Permalink
Fix copy/paste error in RMT
Browse files Browse the repository at this point in the history 
Fixes: #2316
  • Loading branch information
@me-no-dev
me-no-dev authored Jan 14, 2019
1 parent 81844f5 commit 6cf307d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cores/esp32/esp32-hal-rmt.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ bool rmtSetCarrier(rmt_obj_t* rmt, bool carrier_en, bool carrier_level, uint32_t
RMT_MUTEX_LOCK(channel);

RMT.carrier_duty_ch[channel].low = low;
RMT.carrier_duty_ch[channel].low = high;
RMT.carrier_duty_ch[channel].high = high;
RMT.conf_ch[channel].conf0.carrier_en = carrier_en;
RMT.conf_ch[channel].conf0.carrier_out_lv = carrier_level;

Expand Down

2 comments on commit 6cf307d

@cyberman54
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like an important change, but i don't overlook the context.
What side effects had this bug before, is it urgent to update running devices in the field?

@cyberman54
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, got it, this seems to apply only to the infrared module.

Please sign in to comment.