Fix another named export bug. #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, consider external module d3-selection:
import Selection from "./src/selection";
export {Selection as selection};
And entry module:
import {selection} from "d3-selection";
export {selection};
Previously, this would fail with an error saying that d3-selection did not
export "selection". (The code thought it exported "Selection".) In addition to
the doesExport fix, we also need to fix the resolve chains to follow aliases.
|
Found another bug and added a commit. |
|
Perfect timing, I was just about to merge this. Have added a test for the first commit (this library's test suite has grown pretty woolly, I really need to sort it out), will put in a second one and release 0.7.2 momentarily. Thanks! |
Rich-Harris
added a commit
that referenced
this pull request
May 29, 2015
|
Released 0.7.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #145 #169. This one occurred with bundle.toUmd in strict mode.