Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After Stage merge #6993 I lost sntp functionality #7092

Closed
arendst opened this issue Feb 19, 2020 · 3 comments · Fixed by #7097
Closed

After Stage merge #6993 I lost sntp functionality #7092

arendst opened this issue Feb 19, 2020 · 3 comments · Fixed by #7097

Comments

@arendst
Copy link

arendst commented Feb 19, 2020

Using Tasmota on Arduino core stage after merge #6993 I lost sntp functionality and compilation fails with Undefined References to the once documented SNTP API calls by espressif:

  • sntp_get_real_time
  • sntp_get_current_timestamp
  • sntp_set_timezone

I guess some functionality has been dropped...

For sntp_get_real_time I'll make a workaround saving 1k code space anyway. The others still break compilation

@d-a-v d-a-v self-assigned this Feb 19, 2020
@d-a-v d-a-v added this to the 2.7.0 milestone Feb 19, 2020
@d-a-v
Copy link
Collaborator

d-a-v commented Feb 19, 2020

Sorry for that @arendst I focus too much on internals and Arduino API, not espressif API :]
I will re-add these asap.

@d-a-v
Copy link
Collaborator

d-a-v commented Feb 20, 2020

@arendst sntp_get_real_time() returns this string.

ctime() would return Mon Mar 4 21:22:16 2019 so I guess it'd be what you expect, do you confirm ?
I'll propose wrappers mocking espressif API around callers to standard functions.

@arendst
Copy link
Author

arendst commented Feb 20, 2020

@d-a-v confirmed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants