Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obsolete warning comment; copyright header missing #6050

Closed
dok-net opened this issue May 5, 2019 · 2 comments · Fixed by #7653
Closed

Obsolete warning comment; copyright header missing #6050

dok-net opened this issue May 5, 2019 · 2 comments · Fixed by #7653
Assignees
Labels
waiting for feedback Waiting on additional info. If it's not received, the issue may be closed.

Comments

@dok-net
Copy link
Contributor

dok-net commented May 5, 2019


@hreintke What is your opinion on:

  • removing the warning?
  • the proper copyright notice
  • is the limit on SCHEDULED_FN_MAX_COUNT 32 still reasonable in the light of increased use for scheduled interrupts? Of the top of my mind, using scheduled interrupts for SW Serial, there are a lot of interrupts in a short interval of time :-)
@devyte
Copy link
Collaborator

devyte commented May 6, 2019

@dok-net the reason for this limit is that alloced nodes don't ever get freed. Instead, they get saved for recycling.
The original code had a limit of 10 (if memory serves). When this code was updated, we decided on a limit of 32. The thinking was that, if you have to queue more than 32 callbacks before unwinding in the loop, you probably have bigger problems in your sketch that should be solved first.
So, before the limit is increased, I'd like to see a real(istic) example of how the current limit of 32 can be hit. Can you please provide one?

@devyte devyte added the waiting for feedback Waiting on additional info. If it's not received, the issue may be closed. label May 6, 2019
@dok-net
Copy link
Contributor Author

dok-net commented Dec 2, 2019

CoopTask can use cores/esp8266/Schedule for round-robin scheduling, but the device won't handle as many tasks to let the 32 limit become a problem.
@devyte There's still no copyright notice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for feedback Waiting on additional info. If it's not received, the issue may be closed.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants