Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider releasing patch release with fix for home_chan_dwell_time #277

Closed
faern opened this issue Jul 23, 2023 · 4 comments
Closed

Consider releasing patch release with fix for home_chan_dwell_time #277

faern opened this issue Jul 23, 2023 · 4 comments

Comments

@faern
Copy link

faern commented Jul 23, 2023

Building esp-idf-svc against ESP-IDF 4.4, 5.1 and master is broken due to espressif/esp-idf#11921 / esp-rs/esp-idf-template#139.

This has been fixed in commit 42e60e8, but not yet released on crates.io. Could you please consider making a patch release? Currently nothing builds unless you replace your esp-idf-svc dependencies with the git master version.

I'm creating this issue to be able to track a release. But also because there are zero hits in the issue tracker for "home_chan_dwell_time". So this can be a landing for everyone who hits this error.

missing field `home_chan_dwell_time` in initializer of `esp_idf_sys::wifi_scan_config_t`
@MihaMarkic
Copy link

unless you replace your esp-idf-svc dependencies with the git master version

So, what exactly is the way to do it (consider myself as Rust newbie)? Get sources (including patch) from git and use them instead of crate?

@MihaMarkic
Copy link

Just in case anybody else was wondering, placing this in Cargo.toml seems to work:

[patch.crates-io]
esp-idf-svc = { git = "https://github.com/esp-rs/esp-idf-svc" }

@flyaruu
Copy link

flyaruu commented Jul 30, 2023

Indeed, a patch release would be really welcome.

@ivmarkov
Copy link
Collaborator

0.46.1 released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants