Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update RuleDefinition with meta.defaultOptions #150

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request?

Adds defaultOptions to RulesMeta in @eslint/core types.

What changes did you make? (Give an overview)

Copied this:

https://github.com/eslint/eslint/blob/758c66bc8d83cd4eda9639b0745f0d0fb70f04f4/lib/types/index.d.ts#L744-L745

Also added schema, defaultOptions, and context.options in tests.

Related Issues

eslint/eslint#17656

Is there anything you'd like reviewers to focus on?

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@nzakas nzakas merged commit e9a987e into main Jan 31, 2025
18 checks passed
@nzakas nzakas deleted the default-options branch January 31, 2025 16:41
@github-actions github-actions bot mentioned this pull request Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

2 participants