Fix: Add space between async and param on fix (fixes #8682) #8693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
@soda0289, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vitorbal, @not-an-aardvark and @nfroidure to be potential reviewers. |
kaicataldo
added
accepted
kaicataldo
approved these changes
Jun 7, 2017
lib/rules/arrow-parens.js
Outdated
| /** | ||
| * Determines whether a arrow function argument end with `)` | ||
| * @param {ASTNode} node The arrow function node. | ||
| * @returns {void} | ||
| */ | ||
| function parens(node) { | ||
| const token = sourceCode.getFirstToken(node, node.async ? 1 : 0); | ||
| const isAsync = node.async; | ||
| const token = sourceCode.getFirstToken(node, isAsync ? 1 : 0); |
There was a problem hiding this comment.
I know this was here before, but can you give this variable a more descriptive name? It's not clear which token it's referring to.
lib/rules/arrow-parens.js
Outdated
| function fixParamsWithParenthesis(fixer) { | ||
| const paramToken = context.getTokenAfter(token); | ||
| const closingParenToken = context.getTokenAfter(paramToken); | ||
| const asyncToken = isAsync ? context.getTokenBefore(token) : null; |
There was a problem hiding this comment.
Can you use sourceCode.getTokenBefore and sourceCode.getTokenAfter instead of context.getTokenBefore and context.getTokenAfter? The latter two are deprecated.
|
LGTM |
|
LGTM |
|
Changes:
|
kaicataldo
approved these changes
Jun 7, 2017
not-an-aardvark
approved these changes
Jun 7, 2017
gyandeeps
approved these changes
Jun 7, 2017
|
Thanks for contributing! |
This was referenced Jun 23, 2017
This was referenced Jul 7, 2017
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ X ] Bug fix (template)
What changes did you make? (Give an overview)
Update the fixer code to add space between async and the arrow function parameter when they are side by side.
Is there anything you'd like reviewers to focus on?
Nothing in particular