Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(always-return): false positives for logical expr #363

Merged
merged 1 commit into from
Sep 29, 2022
Merged

Conversation

ota-meshi
Copy link
Member

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • New rule
  • Changes an existing rule
  • Add autofixing to a rule
  • Other, please explain:

What changes did you make? (Give an overview)

This PR modifies the always-return rule to correctly use codepath analysis.
This change also reduced unnecessary branching.

close #213

@MichaelDeBoey MichaelDeBoey merged commit a60d1cb into main Sep 29, 2022
@MichaelDeBoey MichaelDeBoey deleted the issue213 branch September 29, 2022 22:28
@github-actions
Copy link
Contributor

🎉 This PR is included in version 6.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5.1.0 - Each then() should return a value or throw
2 participants