fix(prefer-node-protocol): continue on version range check #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderaiser
commented
Mar 20, 2024
| `, | ||
| output: ` | ||
| const fs = require("fs"); | ||
| import buffer from 'node:buffer' |
There was a problem hiding this comment.
node: protocol in CJS isn't supported in v12.20, but it is already supported in ESM, so only ESM fixed. Rare case but still possible with help of createRequire()
scagood
changed the title
This was referenced May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have different supported versions range for
node:protocol in ESM and CJS so it is better to also usecontinuehere, it's more safe to make such transformations and also more clear.