From f09d6c4b630dcab6ff0e9438f2202c0b44414b27 Mon Sep 17 00:00:00 2001 From: coderaiser Date: Wed, 20 Mar 2024 12:27:26 +0200 Subject: [PATCH] fix: prefer-node-protocol: not first target --- lib/rules/prefer-node-protocol.js | 2 +- tests/lib/rules/prefer-node-protocol.js | 11 +++++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/lib/rules/prefer-node-protocol.js b/lib/rules/prefer-node-protocol.js index a26a82ef..1433f787 100644 --- a/lib/rules/prefer-node-protocol.js +++ b/lib/rules/prefer-node-protocol.js @@ -124,7 +124,7 @@ module.exports = { !isBuiltinModule(value) || !isBuiltinModule(`node:${value}`) ) { - return + continue } context.report({ diff --git a/tests/lib/rules/prefer-node-protocol.js b/tests/lib/rules/prefer-node-protocol.js index ea99cc1c..039a61a9 100644 --- a/tests/lib/rules/prefer-node-protocol.js +++ b/tests/lib/rules/prefer-node-protocol.js @@ -191,6 +191,17 @@ new RuleTester({ output: "const fs = require('node:fs/promises')", errors: ["Prefer `node:fs/promises` over `fs/promises`."], }, + { + code: ` + const express = require('express'); + const fs = require('fs/promises'); + `, + output: ` + const express = require('express'); + const fs = require('node:fs/promises'); + `, + errors: ["Prefer `node:fs/promises` over `fs/promises`."], + }, // check enabling by supported Node.js versions {