Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node-builtins): Add node globals #261

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

scagood
Copy link

@scagood scagood commented Apr 30, 2024

This is my best effort to transcribe https://nodejs.org/api/globals.html into eslint-plugin-n format 😄

@scagood
Copy link
Author

scagood commented Apr 30, 2024

@scagood scagood linked an issue Apr 30, 2024 that may be closed by this pull request
1 task
@aladdin-add aladdin-add changed the title chore: Update buffer + stream modules feat: Update buffer + stream modules Apr 30, 2024
@aladdin-add
Copy link

looks great! 👍

should we remove these from es globals?

@scagood scagood changed the title feat: Update buffer + stream modules feat(node-builtins): Add node globals Apr 30, 2024
@scagood
Copy link
Author

scagood commented Apr 30, 2024

mmm, I would need to update this script then regenerate the entire file:

#174 (comment)

I think I should do that separately

@aladdin-add
Copy link

Please feel free to merge as you see fit. 😄

@scagood scagood marked this pull request as ready for review April 30, 2024 09:41
@scagood scagood merged commit 9466731 into eslint-community:master Apr 30, 2024
17 checks passed
@scagood scagood deleted the node-globals branch April 30, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants