From 14d2ea90c1609b49e95cc805105711c62bf6fd50 Mon Sep 17 00:00:00 2001 From: coderaiser Date: Wed, 20 Mar 2024 13:23:16 +0200 Subject: [PATCH] fix(prefer-node-protocol): continue on version range check (#206) --- lib/rules/prefer-node-protocol.js | 2 +- tests/lib/rules/prefer-node-protocol.js | 12 ++++++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/lib/rules/prefer-node-protocol.js b/lib/rules/prefer-node-protocol.js index 1433f787..f6133a98 100644 --- a/lib/rules/prefer-node-protocol.js +++ b/lib/rules/prefer-node-protocol.js @@ -110,7 +110,7 @@ module.exports = { "Program:exit"() { for (const { node, moduleStyle } of targets) { if (!isEnablingThisRule(context, moduleStyle)) { - return + continue } if (node.type === "TemplateLiteral") { diff --git a/tests/lib/rules/prefer-node-protocol.js b/tests/lib/rules/prefer-node-protocol.js index 039a61a9..5db6103c 100644 --- a/tests/lib/rules/prefer-node-protocol.js +++ b/tests/lib/rules/prefer-node-protocol.js @@ -228,5 +228,17 @@ new RuleTester({ output: 'const fs = require("node:fs");', errors: ["Prefer `node:fs` over `fs`."], }, + { + options: [{ version: "12.20.0" }], + code: ` + const fs = require("fs"); + import buffer from 'buffer' + `, + output: ` + const fs = require("fs"); + import buffer from 'node:buffer' + `, + errors: ["Prefer `node:buffer` over `buffer`."], + }, ], })