Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update eslint-plugin-vue + update configs #25

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Conversation

MichaelDeBoey
Copy link
Member

@MichaelDeBoey MichaelDeBoey commented Oct 16, 2022

Re-submission of mysticatea#43


BREAKING CHANGE: es5, es2015, es2016, es2017, es2018, es2019, es2020, es2021 & es2022 configs now have extra rules from eslint-plugin-vue

@MichaelDeBoey MichaelDeBoey requested a review from a team October 16, 2022 18:45
@MichaelDeBoey MichaelDeBoey self-assigned this Oct 16, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2022

Codecov Report

Base: 97.17% // Head: 97.17% // No change to project coverage 👍

Coverage data is based on head (8131cd4) compared to base (0f90860).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha      #25   +/-   ##
=======================================
  Coverage   97.17%   97.17%           
=======================================
  Files          39       39           
  Lines         390      390           
=======================================
  Hits          379      379           
  Misses         11       11           
Impacted Files Coverage Δ
lib/configs/_override-vue.js 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MichaelDeBoey
Copy link
Member Author

@eslint-community/eslint-tsc @eslint-community/core-team @eslint-community/mysticatea-eslint-plugin Since this plugin is adhering the same semantic versioning policy as ESLint, adding new rules to a plugin would be a breaking change, so this PR would need to be released in a major release I guess?

@MichaelDeBoey MichaelDeBoey requested review from a team October 16, 2022 18:55
@MichaelDeBoey MichaelDeBoey marked this pull request as draft October 16, 2022 18:55
package.json Outdated Show resolved Hide resolved
@MichaelDeBoey MichaelDeBoey changed the base branch from main to alpha October 16, 2022 23:15
@MichaelDeBoey MichaelDeBoey marked this pull request as ready for review October 17, 2022 17:21
BREAKING CHANGE: `es5`, `es2015`, `es2016`, `es2017`, `es2018`, `es2019`, `es2020`, `es2021` & `es2022` configs now have extra rules from `eslint-plugin-vue`
@github-actions
Copy link

🎉 This PR is included in version 15.0.0-alpha.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 15.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 15.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants