Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: allow setting the FPACK dither seed #351

Closed
dstndstn opened this issue Jul 22, 2022 · 2 comments · Fixed by #411
Closed

Feature request: allow setting the FPACK dither seed #351

dstndstn opened this issue Jul 22, 2022 · 2 comments · Fixed by #411

Comments

@dstndstn
Copy link
Contributor

Hi,

I'm trying to make it so my code writes bit-identical outputs every time it runs, but I'm using the compression schemes that do the subtractive dither thing, so there is a seed chosen at run-time. It looks like CFITSIO has routines to set that seed -
fits_set_quantize_dither() or fits_set_dither_seed() etc
https://heasarc.gsfc.nasa.gov/docs/software/fitsio/c/c_user/node41.html

It looks like one place to add this feature would be here,

PyFITSObject_create_image_hdu(struct PyFITSObject* self, PyObject* args, PyObject* kwds) {

ie similar to how the quantization level can be set,
if (fits_set_quantize_level(self->fits, qlevel, &status)) {

thanks!
-dustin

@esheldon
Copy link
Owner

Good idea Dustin. Do you want to take a shot at it?

@dstndstn
Copy link
Contributor Author

Maybe :) this isn't at the top of the priority stack at the moment though...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants