Skip to content
This repository has been archived by the owner on Oct 18, 2023. It is now read-only.

fix: support node:test in node 18 #33

Merged
merged 9 commits into from
Jul 12, 2022
Merged

Conversation

privatenumber
Copy link
Member

closes #32

@andrewbranch
Copy link

Looking forward to this landing, thanks! Can I ask why it ever makes sense to strip off a node:?

@privatenumber
Copy link
Member Author

It was one of the minor itches that motivated this project. It's commonly used in latest Sindre Sorhus packages which breaks older versions of Node.js.

esbuild supports downgrading node: imports by stripping them, but only in Build mode.

Will fix in CJS loader soon.

@privatenumber privatenumber marked this pull request as ready for review July 12, 2022 20:33
@privatenumber privatenumber merged commit 5b374fb into develop Jul 12, 2022
@privatenumber privatenumber deleted the fix-import-node-test branch July 12, 2022 20:34
@privatenumber
Copy link
Member Author

🎉 This PR is included in version 2.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node: prefix cannot always be stripped
2 participants