Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Element Type - REV #105

Closed
rompik opened this issue Sep 5, 2022 · 9 comments
Closed

New Element Type - REV #105

rompik opened this issue Sep 5, 2022 · 9 comments
Labels
PipeCAD PipeCAD core issues

Comments

@rompik
Copy link
Contributor

rompik commented Sep 5, 2022

Hello Shing,
Please, can you add new type REV (Revision) with next attributes:

  • Number - type STRING to use alphabet or numeric numbering
  • Date - type DATETIME
  • Description - type STRING
  • Drawed - type STRING
  • Checked - type STRING
  • Approved - type STRING

This new element will be available to place inside Pipe on branch level like on image (like example)
изображение

It will allow providing revision information in PipeCAD for later placing it on iso. In the same I will prepare form for creating Revisions and filling all required attributes for selectected pipes.

@eryar
Copy link
Owner

eryar commented Sep 5, 2022

Hello Roman,
Which version of E3D do you use?
I found the REVI element belongs to DRWG/SHEET not under PIPE:
image

@rompik
Copy link
Contributor Author

rompik commented Sep 5, 2022

I just used E3D2.1/3.1 like a background for my picture. Yes, REVI element is existing in E3D only for Draw but not for Design. In my company for Design we use TEXT element inside pipe to store revision information. But I think will be better if we will have dedicated element REV/REVI inside Design (later in Draw) for such purpose. I want to take the effective things from E3D/PDMS but avoid their limitations:) Currently REVI element will be used like a simple storage of revision information, later it can be setup mechanism which will allow get difference in pipe between 2 revisions like DB Changes menu in PDMS/E3D.

@eryar
Copy link
Owner

eryar commented Sep 5, 2022

Okay. I will add REVI for PIPE in next version.
This will lead to change DB file.

If you have used PipeCAD in project already, the next version will need update project DB files.

@rompik
Copy link
Contributor Author

rompik commented Sep 5, 2022

Currently, I just completely reinstall PipeCAD with newer version w/out keeping database. But will be useful to add to documentation, way for updating databases between versions. Do you have any procedure for that?

@eryar
Copy link
Owner

eryar commented Sep 5, 2022

Add new element type will lead to database change.
Currently PipeCAD function is not complete, I think when funcion completed then will avoid to change database.

@eryar
Copy link
Owner

eryar commented Sep 5, 2022

If you use the sample project in installation that will be OK.

@eryar eryar added the PipeCAD PipeCAD core issues label Sep 10, 2022
@eryar
Copy link
Owner

eryar commented Sep 10, 2022

REVI attributes:

Name Details
Name Name of the element
Description Description of the element
Number Revision number
Author Revision author
Datetime Datetime of revision
Checker Checker
Chkdate Datetime checked
Approver Approver
Appdate Datetime of approval
Stext S Text string

@eryar
Copy link
Owner

eryar commented Sep 10, 2022

Add REVI for PIPE element:
image

@rompik
Copy link
Contributor Author

rompik commented Oct 6, 2022

Added Rev Manager Utility #121

@rompik rompik closed this as completed Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PipeCAD PipeCAD core issues
Projects
Status: Done
Development

No branches or pull requests

2 participants