Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

John Gruber's test suite #99

Closed
wkpark opened this issue Feb 13, 2014 · 3 comments
Closed

John Gruber's test suite #99

wkpark opened this issue Feb 13, 2014 · 3 comments

Comments

@wkpark
Copy link
Contributor

wkpark commented Feb 13, 2014

This is a John Gruber's test suite
http://daringfireball.net/projects/downloads/MarkdownTest_1.0.zip

and the following example rendered incorrectly by the parsedown.

In Markdown 1.0.0 and earlier. Version
8. This line turns into a list item.
Because a hard-wrapped line in the
middle of a paragraph looked like a
list item.

Here's one with a bullet.
* criminey.

In Markdown 1.0.0 and earlier. Version
8. This line turns into a list item.
Because a hard-wrapped line in the
middle of a paragraph looked like a
list item.

Here's one with a bullet.

  • criminey.

babelmark2 result:
http://johnmacfarlane.net/babelmark2/?text=In+Markdown+1.0.0+and+earlier.+Version%0A8.+This+line+turns+into+a+list+item.%0ABecause+a+hard-wrapped+line+in+the%0Amiddle+of+a+paragraph+looked+like+a%0Alist+item.%0A%0AHere%27s+one+with+a+bullet.%0A*+criminey.

@hkdobrev
Copy link
Contributor

@wkpark Great catch!

I saw a separate and not so important issue about ordered lists in your example. Parsedown should use the start attribute on ol elements. I'll submit another issue for that.

@wkpark
Copy link
Contributor Author

wkpark commented Feb 17, 2014

This is the Markdown testsuite by John Gruber and the Markdown 1.0.2b8

https://github.com/wkpark/markdown-testsuite

@aidantwoods
Copy link
Collaborator

We now test against (but do not currently pass all of) the CommonMark examples. CommonMark is a bit more specific than John Gruber's original Markdown spec, so I think that testing against John Gruber's suite is probably no longer needed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants