List parse error

[zerbbi]

Hello, i found problems when using (un)ordered lists. Parser is rendering weird characters when using special characters like č ž ť. When i remove list, text is rendered correctly. Here is screenshot, input is on the left half of picture and result is on the right. I found that this issue is related with substr_replace. I changed code in vendor/erusev/parsedown/Parsedown.php on line 1461 to $markup = substr($markup, 0, $position - strlen($markup)); and now, everything is working. Also this problem happens only when server is having set mbstring.func_overload = 7

test text:

* test
* hocičo
* assasasss
* lorem ipsum
* kúsky čriev
* hocičo

screenshot:

[erusev]

can u reproduce this on http://parsedown.org/demo

[zerbbi]

it is working correctly in demo, this bug only happens when server has mbstring.func_overload set to 7.

[erusev]

i'm not familiar with that server configuration

[ziqbal]

mbstring.func_overload can cause issues:

http://stackoverflow.com/questions/222630/should-i-use-multi-byte-overloading-mbstring-func-overload

[Zegnat]

Several security libraries have had problems with this, as strlen suddenly would not work as a binary counter anymore. The fix is relatively easy and if you know what functions are causing the problem in ParseDown those could easily be patched.

See this patch on the password_compat library: #40 diff line 220.

[Zegnat]

Actually, this is a duplicate of #378 and the final comment features the same fix as mine.