Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for inline images #390

Closed
Yirg opened this issue Mar 4, 2016 · 4 comments
Closed

Support for inline images #390

Yirg opened this issue Mar 4, 2016 · 4 comments
Labels

Comments

@Yirg
Copy link

Yirg commented Mar 4, 2016

I'd like to be able to write illustrated guides with inline images, but it seems Parsedown always pushes images to the bottom of the post. Is there a way to embed images inline, and if not, may I suggest it as an enhancement?

Thank you!

@cebe
Copy link
Contributor

cebe commented Mar 4, 2016

All images should be inline by default. Can you show your markdown and the parsed output HTML?

@Yirg
Copy link
Author

Yirg commented Mar 4, 2016

See for example the text in this giveaway description on steamgifts.com.

Both images here appear after both paragraphs, but if you check the code you'll see that the second paragraph should actually be after the first image. This is the code:

Paragraph #1

![Image #1](http://cdn.akamai.steamstatic.com/steam/apps/318570/header_292x136.jpg)

Paragraph #2

![Image #2](http://cdn.akamai.steamstatic.com/steam/apps/306950/header_292x136.jpg)

And this is the resulting order:

Paragraph #1
Paragraph #2
View attached image.
View attached image.

@cebe
Copy link
Contributor

cebe commented Mar 4, 2016

This is not a problem with parsedown but with the site you are using. The above markdown renders as expected on http://parsedown.org/demo :

<p>Paragraph #1</p>
<p><img src="http://cdn.akamai.steamstatic.com/steam/apps/318570/header_292x136.jpg" alt="Image #1" /></p>
<p>Paragraph #2</p>
<p><img src="http://cdn.akamai.steamstatic.com/steam/apps/306950/header_292x136.jpg" alt="Image #2" /></p>

@Yirg
Copy link
Author

Yirg commented Mar 4, 2016

Thank you for helping, cebe. I'll discuss this with the site admin.

Have a great weekend!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants