Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action installs dependencies at runtime #136

Closed
ekohl opened this issue Oct 10, 2024 · 1 comment
Closed

Action installs dependencies at runtime #136

ekohl opened this issue Oct 10, 2024 · 1 comment

Comments

@ekohl
Copy link

ekohl commented Oct 10, 2024

Currently the action installs its dependencies at runtime:

vale-action/src/input.ts

Lines 54 to 58 in 3a4769d

await exec.exec('pip', ['install', 'docutils']);
logIfDebug('`pip install docutils` complete');
await exec.exec('gem', ['install', 'asciidoctor', '--user-install']);
logIfDebug('`gem install asciidoctor --user-install` complete');

Then it also installs Vale and Reviewdog in https://github.com/errata-ai/vale-action/blob/reviewdog/src/install.ts.

This makes the action slower than it needs to be and also causes issues like #111 and #128.

My suggestion would be to start using an image that contains all the required dependencies. https://docs.github.com/en/actions/sharing-automations/creating-actions/creating-a-docker-container-action describes this process. That's pretty much the opposite of 87aaef6. Sadly there's no PR attached to that commit with any explanation why this new strategy was used.

@jdkato
Copy link
Member

jdkato commented Oct 10, 2024

Vale and Reviewdog are runtime dependencies in so much as their versions are configurable.

Using Docker (even a pre-built image) for the other 2 is not faster.

@jdkato jdkato closed this as not planned Won't fix, can't repro, duplicate, stale Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants