From ed284fd315e1bfd68fca342b50f8cfaf4cb44f96 Mon Sep 17 00:00:00 2001 From: ZhidaLiu <86350902+ZhidaLiu@users.noreply.github.com> Date: Tue, 11 Jan 2022 20:25:57 -0800 Subject: [PATCH 1/6] resolve SystemData error adding ref to Resource to resolve the RequiredReadOnlySystemData error --- .../stable/2021-10-01/machineLearningServices.json | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2021-10-01/machineLearningServices.json b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2021-10-01/machineLearningServices.json index 6e00e3ab6cdf..ad6c7e7ebea9 100644 --- a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2021-10-01/machineLearningServices.json +++ b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2021-10-01/machineLearningServices.json @@ -4754,6 +4754,11 @@ "WorkspaceConnection": { "x-ms-azure-resource": true, "description": "Workspace connection.", + "allOf": [ + { + "$ref": "../../../../../common-types/resource-management/v3/types.json#/definitions/Resource" + } + ], "type": "object", "properties": { "id": { From a3b483046d7a8cc366a1f3797bb8843e41606aaf Mon Sep 17 00:00:00 2001 From: ZhidaLiu <86350902+ZhidaLiu@users.noreply.github.com> Date: Tue, 11 Jan 2022 20:29:55 -0800 Subject: [PATCH 2/6] Resolve missing default response --- .../stable/2021-10-01/machineLearningServices.json | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2021-10-01/machineLearningServices.json b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2021-10-01/machineLearningServices.json index ad6c7e7ebea9..abbc363c6dac 100644 --- a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2021-10-01/machineLearningServices.json +++ b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2021-10-01/machineLearningServices.json @@ -492,6 +492,12 @@ "schema": { "$ref": "#/definitions/ListUsagesResult" } + }, + "default": { + "description": "Error response describing why the operation failed", + "schema": { + "$ref": "../../../../../common-types/resource-management/v3/types.json#/definitions/ErrorResponse" + } } }, "x-ms-pageable": { @@ -1470,6 +1476,12 @@ "schema": { "$ref": "#/definitions/PrivateLinkResourceListResult" } + }, + "default": { + "description": "Error response describing why the operation failed", + "schema": { + "$ref": "../../../../../common-types/resource-management/v3/types.json#/definitions/ErrorResponse" + } } } } From 06a3faca656e7a55ca7a23af20b843a6163afd20 Mon Sep 17 00:00:00 2001 From: ZhidaLiu <86350902+ZhidaLiu@users.noreply.github.com> Date: Tue, 11 Jan 2022 20:42:48 -0800 Subject: [PATCH 3/6] Resolve wrong response schema --- .../stable/2021-10-01/machineLearningServices.json | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2021-10-01/machineLearningServices.json b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2021-10-01/machineLearningServices.json index abbc363c6dac..c4c804f033fc 100644 --- a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2021-10-01/machineLearningServices.json +++ b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2021-10-01/machineLearningServices.json @@ -1994,6 +1994,10 @@ "type": "string" } } + }, + "isDataAction": { + "description": "Indicates whether the operation applies to data-plane", + "type": "boolean" } } }, From 1caf28be80628a4372438e0f8438a4a236a61399 Mon Sep 17 00:00:00 2001 From: ZhidaLiu <86350902+ZhidaLiu@users.noreply.github.com> Date: Tue, 11 Jan 2022 20:44:05 -0800 Subject: [PATCH 4/6] Add missing Object type --- .../stable/2021-10-01/workspaceFeatures.json | 1 + 1 file changed, 1 insertion(+) diff --git a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2021-10-01/workspaceFeatures.json b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2021-10-01/workspaceFeatures.json index b7aa83a88525..d2edfbb0d4fe 100644 --- a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2021-10-01/workspaceFeatures.json +++ b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2021-10-01/workspaceFeatures.json @@ -81,6 +81,7 @@ } }, "ListAmlUserFeatureResult": { + "type": "object", "properties": { "value": { "readOnly": true, From 75d21795ab3187167858777841b9849f189299d9 Mon Sep 17 00:00:00 2001 From: ZhidaLiu <86350902+ZhidaLiu@users.noreply.github.com> Date: Wed, 12 Jan 2022 10:44:25 -0800 Subject: [PATCH 5/6] Remove duplicate properties after using AllOf keyword --- .../2021-10-01/machineLearningServices.json | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2021-10-01/machineLearningServices.json b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2021-10-01/machineLearningServices.json index c4c804f033fc..f549a279800b 100644 --- a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2021-10-01/machineLearningServices.json +++ b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2021-10-01/machineLearningServices.json @@ -4777,21 +4777,6 @@ ], "type": "object", "properties": { - "id": { - "type": "string", - "description": "ResourceId of the workspace connection.", - "readOnly": true - }, - "name": { - "type": "string", - "description": "Friendly name of the workspace connection.", - "readOnly": true - }, - "type": { - "type": "string", - "description": "Resource type of workspace connection.", - "readOnly": true - }, "properties": { "type": "object", "description": "Properties of workspace connection.", From 4f5f6d31fd704d79011f706e27c60bc02c493074 Mon Sep 17 00:00:00 2001 From: ZhidaLiu <86350902+ZhidaLiu@users.noreply.github.com> Date: Fri, 14 Jan 2022 10:31:19 -0800 Subject: [PATCH 6/6] Adding missing example and small fix --- .../stable/2021-10-01/examples/Compute/delete.json | 3 ++- .../stable/2021-10-01/machineLearningServices.json | 6 ++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2021-10-01/examples/Compute/delete.json b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2021-10-01/examples/Compute/delete.json index 89d2a2d4d19c..7315283521a2 100644 --- a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2021-10-01/examples/Compute/delete.json +++ b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2021-10-01/examples/Compute/delete.json @@ -14,6 +14,7 @@ "Azure-AsyncOperation": "https://management.azure.com/subscriptions/...pathToOperationStatus...", "Location": "https://management.azure.com/subscriptions/...pathToOperationResult..." } - } + }, + "204": {} } } diff --git a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2021-10-01/machineLearningServices.json b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2021-10-01/machineLearningServices.json index f549a279800b..0e88d9c10b4b 100644 --- a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2021-10-01/machineLearningServices.json +++ b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2021-10-01/machineLearningServices.json @@ -539,6 +539,12 @@ "schema": { "$ref": "#/definitions/VirtualMachineSizeListResult" } + }, + "default": { + "description": "Error response describing why the operation failed.", + "schema": { + "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse" + } } }, "x-ms-examples": {