Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show DryRun scripts as "Running" in the output #619

Open
Tradioyes opened this issue Jan 24, 2025 · 0 comments
Open

Don't show DryRun scripts as "Running" in the output #619

Tradioyes opened this issue Jan 24, 2025 · 0 comments

Comments

@Tradioyes
Copy link

Is your feature request related to a problem? Please describe.
I had a scare while trying scripts before a migration from roundhouse, because when I ran my scripts with the --dryrun option, they still showed as "Running" in the output as opposed to "DryRun" like in RoundHouse.

Describe the solution you'd like
The output could be differentiated when in DryRun mode

Additional context
I think the fix can be done there (and maybe some other places, I have to check) https://github.com/erikbra/grate/blob/main/src/grate.core/Migration/DbMigrator.cs#L90 , I'll try to do it myself next week and send a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant