From 403792d47f2347fe973e7b75079b9cb9563d6d00 Mon Sep 17 00:00:00 2001 From: lupin012 <58134934+lupin012@users.noreply.github.com> Date: Tue, 11 Jun 2024 23:50:30 +0200 Subject: [PATCH 1/2] update ignore api list and add subtest ignore list --- silkworm/rpc/commands/rpc_api_test.cpp | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/silkworm/rpc/commands/rpc_api_test.cpp b/silkworm/rpc/commands/rpc_api_test.cpp index 9c672d87f1..30e5cd6588 100644 --- a/silkworm/rpc/commands/rpc_api_test.cpp +++ b/silkworm/rpc/commands/rpc_api_test.cpp @@ -65,12 +65,15 @@ bool are_equivalent(const nlohmann::json& obj1, const nlohmann::json& obj2) { } static const std::vector tests_to_ignore = { - "eth_estimateGas", // call to oracle fails, needs fixing - "debug_getRawReceipts", // not implemented "eth_getProof", // not implemented - "eth_feeHistory", // history not stored, needs fixing - "eth_sendRawTransaction", // call to oracle fails, needs fixing or mocking - "eth_createAccessList", // expected value doesn't contain gas optimization + "debug_getRawReceipts", // not implemented + "eth_sendRawTransaction", // call to txpool fails, needs mocking +}; + +static const std::vector subtests_to_ignore = { + "create-al-multiple-reads.io", // eth_createAccessList: expected value doesn't contain gas optimization + "estimate-simple-transfer.io", // eth_estimateGas doesn't expect baseFeeGas without GasPrice + "estimate-simple-contract.io", // eth_estimateGas doesn't expect baseFeeGas without GasPrice }; // Exclude tests from sanitizer builds due to ASAN/TSAN warnings inside gRPC library @@ -87,6 +90,10 @@ TEST_CASE("rpc_api io (all files)", "[rpc][rpc_api]") { continue; } + if (std::find(subtests_to_ignore.begin(), subtests_to_ignore.end(), test_name) != subtests_to_ignore.end()) { + continue; + } + std::ifstream test_stream(test_file.path()); if (!test_stream.is_open()) { From 4d9d6b2a0f9ce31f315f573dd5fad4cb40cde17a Mon Sep 17 00:00:00 2001 From: GitHub Date: Tue, 11 Jun 2024 21:51:44 +0000 Subject: [PATCH 2/2] make fmt --- silkworm/rpc/commands/rpc_api_test.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/silkworm/rpc/commands/rpc_api_test.cpp b/silkworm/rpc/commands/rpc_api_test.cpp index 30e5cd6588..a7c95beeda 100644 --- a/silkworm/rpc/commands/rpc_api_test.cpp +++ b/silkworm/rpc/commands/rpc_api_test.cpp @@ -71,9 +71,9 @@ static const std::vector tests_to_ignore = { }; static const std::vector subtests_to_ignore = { - "create-al-multiple-reads.io", // eth_createAccessList: expected value doesn't contain gas optimization - "estimate-simple-transfer.io", // eth_estimateGas doesn't expect baseFeeGas without GasPrice - "estimate-simple-contract.io", // eth_estimateGas doesn't expect baseFeeGas without GasPrice + "create-al-multiple-reads.io", // eth_createAccessList: expected value doesn't contain gas optimization + "estimate-simple-transfer.io", // eth_estimateGas doesn't expect baseFeeGas without GasPrice + "estimate-simple-contract.io", // eth_estimateGas doesn't expect baseFeeGas without GasPrice }; // Exclude tests from sanitizer builds due to ASAN/TSAN warnings inside gRPC library