diagnostics: all pprofs #11891
Merged
diagnostics: all pprofs #11891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shohamc1
reviewed
Sep 6, 2024
diagnostics/profile.go
Outdated
|
|
||
| //handle all pprof, supported: goroutine, threadcreate, heap, allocs, block, mutex | ||
| metricsMux.HandleFunc("/pprof/", func(w http.ResponseWriter, r *http.Request) { | ||
| profile := r.URL.Path[len("/pprof/"):] |
There was a problem hiding this comment.
You can use strings.TrimPrefix. Alternatively, you can also use HTTP params using r.URL.Query().Get("profile"), but this changes your request format to /pprof?profile=<name>.
diagnostics/profile.go
Outdated
| }) | ||
| } | ||
|
|
||
| func writePproProfile(w http.ResponseWriter, profile string) { |
There was a problem hiding this comment.
Suggested change
| func writePproProfile(w http.ResponseWriter, profile string) { | |
| func writeProfProfile(w http.ResponseWriter, profile string) { |
There was a problem hiding this comment.
fixed typo, I want it to have "Pprof" to point that I and getting data from this lib
taratorio
approved these changes
Sep 6, 2024
dvovk
added a commit
that referenced
this pull request
Sep 7, 2024
Extended pprof read API to include: goroutine, threadcreate, heap, allocs, block, mutex
dvovk
added a commit
that referenced
this pull request
Sep 7, 2024
Extended pprof read API to include: goroutine, threadcreate, heap, allocs, block, mutex
AskAlexSharov
pushed a commit
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended pprof read API to include: goroutine, threadcreate, heap, allocs, block, mutex