Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accumulator StateChanges must use SerialiseV3/DeserialiseV3 for accounts #12480

Closed
AskAlexSharov opened this issue Oct 25, 2024 · 0 comments · Fixed by #13390
Closed

Accumulator StateChanges must use SerialiseV3/DeserialiseV3 for accounts #12480

AskAlexSharov opened this issue Oct 25, 2024 · 0 comments · Fixed by #13390
Assignees
Labels
erigon3 imp1 High importance
Milestone

Comments

@AskAlexSharov
Copy link
Collaborator

AskAlexSharov commented Oct 25, 2024

now i see:

newV := make([]byte, acc.EncodingLengthForStorage())
acc.EncodeForStorage(newV)
if accumulator != nil {
	accumulator.ChangeAccount(address, acc.Incarnation, newV)
}

same in TxPool - it does decode this value.

also all tests need move from DecodeIncarnationFromStorage to DeserialiseV3

@AskAlexSharov AskAlexSharov added imp1 High importance erigon3 labels Oct 25, 2024
@AskAlexSharov AskAlexSharov added this to the 3.0.0-alpha6 milestone Oct 25, 2024
@AskAlexSharov AskAlexSharov added imp2 Medium importance and removed imp1 High importance labels Oct 25, 2024
@AskAlexSharov AskAlexSharov added imp1 High importance and removed imp2 Medium importance labels Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
erigon3 imp1 High importance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@AskAlexSharov @JkLondon and others