Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review the Database models for attributes which should or should not be required #1270

Closed
UsamaEquinorAFK opened this issue Dec 18, 2023 · 0 comments · Fixed by #1309
Closed

Review the Database models for attributes which should or should not be required #1270

UsamaEquinorAFK opened this issue Dec 18, 2023 · 0 comments · Fixed by #1309
Assignees
@andchiind
Labels
backend Backend related functionality improvement Improvement to existing functionality

Comments

@UsamaEquinorAFK
Copy link
Contributor

UsamaEquinorAFK commented Dec 18, 2023 •
edited
Loading

Describe the improvement you would like to see

Some of the database models carry attributes should be checked if they are required or not required. For example TagID in MissionTask and Area in MissionRun.

How will this change existing functionality?

Make the code in services and eventhandlers better and would be lesser null checks.

How will this improvement affect the current Threat Model?
NA.
@UsamaEquinorAFK UsamaEquinorAFK added backend Backend related functionality improvement Improvement to existing functionality labels Dec 18, 2023
@andchiind andchiind self-assigned this Jan 4, 2024
@andchiind andchiind mentioned this issue Jan 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andchiind andchiind

Labels
backend Backend related functionality improvement Improvement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make more fields required andchiind/flotilla
2 participants
@andchiind @UsamaEquinorAFK