Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflows failing due to updated git #7841

Closed
yngve-sk opened this issue May 6, 2024 · 1 comment · Fixed by #7847
Closed

Workflows failing due to updated git #7841

yngve-sk opened this issue May 6, 2024 · 1 comment · Fixed by #7847
Assignees
Labels

Comments

@yngve-sk
Copy link
Contributor

yngve-sk commented May 6, 2024

Workflows failing on linux for python 3.8, 3.9, 3.10, due to setuptools failing to parse trailing Z at timestamp generated by git command. Setuptools will likely be updated to handle this in near future, but until then we will not be able to run tests on linux without working around it.

Setuptools issue:
pypa/setuptools-scm#1038
There is a PR which will resolve it, but it is not yet merged:
https://github.com/pypa/setuptools_scm/pull/1039/files

        File "/tmp/pip-build-env-cqob0u5m/overlay/lib/python3.10/site-packages/setuptools_scm/_get_version_impl.py", line 35, in parse_scm_version
          return _entrypoints.version_from_entrypoint(
        File "/tmp/pip-build-env-cqob0u5m/overlay/lib/python3.10/site-packages/setuptools_scm/_entrypoints.py", line 55, in version_from_entrypoint
          maybe_version: version.ScmVersion | None = fn(root, config=config)
        File "/tmp/pip-build-env-cqob0u5m/overlay/lib/python3.10/site-packages/setuptools_scm/git.py", line 211, in parse
          return _git_parse_inner(
        File "/tmp/pip-build-env-cqob0u5m/overlay/lib/python3.10/site-packages/setuptools_scm/git.py", line 272, in _git_parse_inner
          node_date = wd.get_head_date() or datetime.now(timezone.utc).date()
        File "/tmp/pip-build-env-cqob0u5m/overlay/lib/python3.10/site-packages/setuptools_scm/git.py", line 131, in get_head_date
          return res.parse_success(
        File "/tmp/pip-build-env-cqob0u5m/overlay/lib/python3.10/site-packages/setuptools_scm/_run_cmd.py", line 77, in parse_success
          return parse(self.stdout)
        File "/tmp/pip-build-env-cqob0u5m/overlay/lib/python3.10/site-packages/setuptools_scm/git.py", line 121, in parse_timestamp
          return datetime.fromisoformat(timestamp_text).date()
      ValueError: Invalid isoformat string: '2024-05-06T07:28:45Z'
      [end of output]

Example failures:
https://github.com/equinor/ert/actions/runs/8966427993/job/24621915669
https://github.com/equinor/ert/actions/runs/8967021489/job/24623707207?pr=7840

@yngve-sk yngve-sk added the bug label May 6, 2024
@yngve-sk yngve-sk added this to SCOUT May 6, 2024
@yngve-sk yngve-sk moved this to In Progress in SCOUT May 6, 2024
@larsevj
Copy link
Collaborator

larsevj commented May 6, 2024

Issue seems to be due to updated git in our docker image for linux. Have to wait for new setuptools_scm before unpinning.

@github-project-automation github-project-automation bot moved this from In Progress to Done in SCOUT May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants