Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Autocomplete: revert changes from #3408 #3514

Closed
oddvernes opened this issue Jun 13, 2024 · 0 comments · Fixed by #3515
Closed

🐛 Autocomplete: revert changes from #3408 #3514

oddvernes opened this issue Jun 13, 2024 · 0 comments · Fixed by #3515
Assignees
@oddvernes

Comments

@oddvernes
Copy link
Collaborator

This change meant to improve type-safety of the optionsLabel prop by conditionally making it required when options are objects, is breaking autocomplete typescript for at least two different projects when making a wrapper for Autocomplete. So I think all we can do for now is to restore the old type setup
@oddvernes oddvernes changed the title Autocomplete: revert changes from #3408 🐛 Autocomplete: revert changes from #3408 Jun 13, 2024
This was referenced Jun 13, 2024
Closed
Merged
@oddvernes oddvernes self-assigned this Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oddvernes oddvernes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 Autocomplete: revert 3408 type change + readonly equinor/design-system
1 participant
@oddvernes