Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node metrics with exporter #258

Closed
fracek opened this issue Apr 24, 2022 · 10 comments
Closed

Add node metrics with exporter #258

fracek opened this issue Apr 24, 2022 · 10 comments

Comments

@fracek
Copy link
Contributor

fracek commented Apr 24, 2022

When running the node in production I'm interested in monitoring the overall node's health. It would be sweet to have the node collect several metrics and export them to InfluxDB and/or Prometheus. Go Ethereum offers this feature and I think it's a good reference.

@Mirko-von-Leipzig
Copy link
Contributor

What sort of metrics do you have in mind?

@Mirko-von-Leipzig
Copy link
Contributor

@Mirko-von-Leipzig
Copy link
Contributor

This is something that has been requested a few times now, and its definitely something we want to support.

That said, it will be a medium term objective and not the short term priority.

@fracek
Copy link
Contributor Author

fracek commented May 6, 2022

Sorry for the late reply, for some reasons I didn't see the previous response. What geth does is good enough, even better would be using a standard like opentelemetry for instrumentation and tracing.

@Mirko-von-Leipzig
Copy link
Contributor

Thanks -- will have a look into the standards.

@fracek
Copy link
Contributor Author

fracek commented May 10, 2022

Are you open to external contributions for this? I'm running pathfinder in production and I need this and #194. I can write a more thorough proposal before I start working on this so that we can agree on how it will work.

@Mirko-von-Leipzig
Copy link
Contributor

We would really appreciate a contribution here -- our bandwidth is currently quite limited.

I can write a more thorough proposal before I start working on this so that we can agree on how it will work.

I think this is a great starting point!

And additional note - we will be unavailable next week (16-20 May), so communication will be sparse then.

@CHr15F0x
Copy link
Member

Since #545 and #620 we've got prometheus metrics support as described in the readme file. @fracek are these sufficient for you?

@CHr15F0x CHr15F0x reopened this Oct 25, 2022
@CHr15F0x
Copy link
Member

Sorry, I was about to just comment, not closing yet.

@fracek
Copy link
Contributor Author

fracek commented Oct 25, 2022

Yep, looks good to me. Thank you!

@fracek fracek closed this as completed Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants