Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Set protocol for Vault only in one place in configuration #1413

Closed
erzetpe opened this issue Jul 2, 2020 · 1 comment · Fixed by #1434
Closed

[FEATURE REQUEST] Set protocol for Vault only in one place in configuration #1413

erzetpe opened this issue Jul 2, 2020 · 1 comment · Fixed by #1434

Comments

@erzetpe
Copy link
Contributor

erzetpe commented Jul 2, 2020

Is your feature request related to a problem? Please describe.
We should be able to set protocol for Vault only in one place, not like in the config below:

---
kind: configuration/vault
title: Vault Config
provider: aws
name: default
specification:
  vault_enabled: true
  ...
  **tls_disable: true
  externalVaultAddr: http://external-vault:8200**

This can lead to inconsistency and confusing bugs.

Describe the solution you'd like
I would like to have protocol - http or https configured only in one place.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
No additional context.

@ar3ndt ar3ndt self-assigned this Jul 2, 2020
@erzetpe erzetpe changed the title [FEATURE REQUEST] Short description of the feature request [FEATURE REQUEST] Set protocol for Vault only in one place in configuration Jul 2, 2020
@ar3ndt ar3ndt linked a pull request Jul 7, 2020 that will close this issue
@erzetpe erzetpe assigned erzetpe and unassigned ar3ndt Jul 10, 2020
@mkyc mkyc added this to the 0.7.1 milestone Jul 10, 2020
@mkyc mkyc reopened this Jul 13, 2020
@mkyc mkyc modified the milestones: 0.7.1, S20200729 Jul 17, 2020
@przemyslavic przemyslavic self-assigned this Jul 21, 2020
@przemyslavic
Copy link
Collaborator

It has been tested. The protocol selection (http / https) now depends on the value of the tls_disable parameter and the vault address is built based on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment