Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Device validation error messages #99

Closed
GDYendell opened this issue Feb 21, 2024 · 1 comment · Fixed by #108
Closed

Improve Device validation error messages #99

GDYendell opened this issue Feb 21, 2024 · 1 comment · Fixed by #108

Comments

@GDYendell
Copy link
Member

Currently when validation fails for a Device with parents it is not clear which yaml file the failure is in.

We could catch the error in Device.deserialize and add some context, but this would be too late to tell which yaml file the problem is in because it is all loaded into one dictionary at this point. Perhaps Device.deserialize_parents should validate each as it is loaded and fail at that point.

@GDYendell GDYendell changed the title Imrprove Device validation error messages Improve Device validation error messages Feb 21, 2024
@gilesknap
Copy link
Member

I approve this message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants